Added Temperature sensor support for NetApp #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0o
added a commit
that referenced
this pull request
May 14, 2015
Added Temperature sensor support for NetApp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok a few things on this one:
Check includes/discovery/functions.inc.php. I've updated this as it looks fundamentally wrong as is. This PR was passing those values across and they were being NULL'd out due to this.
I've updated poll_sensor in includes/polling/functions.inc.php to support custom temperature includes and made use of it for this PR. This really shouldn't effect any existing temp sensors.
Screenshot.
Excuse the dip, this is when I was coding the PR.