Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Transition NIDs #9729

Merged
merged 17 commits into from Apr 30, 2019

Conversation

Projects
None yet
5 participants
@JoshWeepie
Copy link
Contributor

commented Jan 24, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

JoshWeepie added some commits Jan 24, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

Hello @JoshWeepie

Thank you for your PR.

Thanx

JoshWeepie added some commits Jan 24, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

Could you please rename the files exactly as the mib name ? (without the extension mostly) and also remove the standard mib files (in the subdir) as we should already have them all ?

JoshWeepie added some commits Jan 24, 2019

@CLAassistant

This comment has been minimized.

Copy link

commented Jan 25, 2019

CLA assistant check
All committers have signed the CLA.

@JoshWeepie

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2019

@PipoCanaja

Removed extensions and standard mibs, currently we are not using mib files for polling and discovery for our Transition devices, just the definitions yaml.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2019

Hello @JoshWeepie
It seems that you removed too much now ... All mibs are gone. Rename got wrong ? You need to use "git mv nameOfFileNotGood.mib NAME-MIB"
PipoCanaja

@JoshWeepie

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

Ah oops, I'll get this fixed

@murrant

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

Sorry to be a bit late here. But why have you included MIBs? You don't seem to use them.

@JoshWeepie

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

I included them because @PipoCanaja asked that they be included in the PR, should we keep them or exclude them?😄 You're correct we are not currently using them and the polling/traffic graphs for our NIDs works correctly.

@murrant

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

I think in this case because there are so many. We can just leave them off for now. If you send a PR that adds sensors or something else that uses them, go ahead and include them there.

Also, you still need to add test data.

@label-actions

This comment has been minimized.

Copy link

commented Feb 7, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@murrant

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

@JoshWeepie Do you plan to add test data? (snmprec at minimum) Otherwise we will need to close this.

@JoshWeepie

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

I do plan on getting it added, we've been super busy and I had an issue trying to get the script to work correctly.

@laf

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

@JoshWeepie Let us know if you need any help with this.

@JoshWeepie

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@laf snmprec added

@laf

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Thanks @JoshWeepie. Is their a better name for this, transition is the company name which we'd avoid using. Do they call the OS something? Model range that this works for?

@JoshWeepie

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

I don't think they call the OS anything, I am successfully polling S3290's and S3280's with the transition.yml file in this commit. Here's the datasheet for one of these https://www.transition.com/products/media-converters/s3290-series/

@laf laf force-pushed the JoshWeepie:patch-5 branch from 74a8480 to 1194110 Apr 14, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@laf you have vlan interfaces ignored. We should probably clear user settings when running tests right?

@murrant murrant merged commit 4e62838 into librenms:master Apr 30, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Add support for Transition NIDs (librenms#9729)
* Add support for Transition NIDs

* Upload Transition logo

* Create transition

* Add files via upload

* Add files via upload

* Delete transition

* Delete MEF-UNI-MIB.smi

* Delete PTP-MIB.smi

* Delete BRIDGE-MIB.smi

* Delete ENTITY-STATE-TC-MIB.smi

removed standard mibs

* remove extensions from mibs

* Create TN-AC-MIB

* Removed extensions from Transition MIBs

* Delete TN-AC-MIB

* Create transition.snmprec

Added test data

* Renamed some mibs + updated tests

* Update transition.json

spencerbutler added a commit to spencerbutler/librenms that referenced this pull request May 21, 2019

Add support for Transition NIDs (librenms#9729)
* Add support for Transition NIDs

* Upload Transition logo

* Create transition

* Add files via upload

* Add files via upload

* Delete transition

* Delete MEF-UNI-MIB.smi

* Delete PTP-MIB.smi

* Delete BRIDGE-MIB.smi

* Delete ENTITY-STATE-TC-MIB.smi

removed standard mibs

* remove extensions from mibs

* Create TN-AC-MIB

* Removed extensions from Transition MIBs

* Delete TN-AC-MIB

* Create transition.snmprec

Added test data

* Renamed some mibs + updated tests

* Update transition.json

@lock lock bot locked as resolved and limited conversation to collaborators Jun 29, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.