Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DKT Comega FTTx devices #9732

Merged
merged 4 commits into from Feb 7, 2019

Conversation

Projects
None yet
2 participants
@PipoCanaja
Copy link
Contributor

commented Jan 25, 2019

Support for DKT Comega device following issue

fixes #9494

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant

murrant approved these changes Feb 7, 2019

Copy link
Member

left a comment

LGTM

@murrant murrant removed the Needs Testing label Feb 7, 2019

@murrant murrant merged commit c7c1ca2 into librenms:master Feb 7, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:dkt branch Feb 7, 2019

sjtarik added a commit to sjtarik/librenms that referenced this pull request Feb 19, 2019

Support for DKT Comega FTTx devices (librenms#9732)
* DKT Comega device support

* DKT Comega device support

* DKT Comega device support

* DKT Comega device support

@lock lock bot locked as resolved and limited conversation to collaborators Apr 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.