Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS.COM (Fiberstore) 'GBN' and 'SWITCH' devices support #9734

Merged
merged 33 commits into from Feb 10, 2019

Conversation

Projects
None yet
3 participants
@PipoCanaja
Copy link
Contributor

commented Jan 25, 2019

Following #9712 and #9117

Mibs are quite buggy but some data is polled (Serial, HW, SW Version, CPU and Memory) on some devices.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja changed the title Fiberstore device support Fiberstore device support (WIP) Jan 25, 2019

@PipoCanaja PipoCanaja changed the title Fiberstore device support (WIP) Fiberstore device support Jan 25, 2019

@Cormoran96

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2019

Works fine for me. Thanks

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Jan 28, 2019

@Cormoran96
Which type of device ? Which sensors are discovered ?
Thx

@Cormoran96

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2019

My bad.

I thought the processor graph start graph but no.

screenshot from 2019-01-28 09-55-50

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Jan 28, 2019

So the 3900 family is different than the 3800 ... It seems that their products are all different, they have completely different MIBs.
The SN, HW and software versions are not collected.

If you can collect snmpwalk as described here, I'll check if something can be done :
https://docs.librenms.org/Support/FAQ/#faq20

@Cormoran96

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2019

If you can collect snmpwalk as described here, I'll check if something can be done

I already do that here #9712

@@ -0,0 +1,140 @@
<?xml version="1.0" encoding="utf-8"?>

This comment has been minimized.

Copy link
@murrant

murrant Jan 29, 2019

Member

This needs to be optimized, I usually just paste it into https://jakearchibald.github.io/svgomg/

@murrant

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

Looks good overall. I'm a but unsure about the OS name.
According to the MIBs, it should probably be called GBN.
The enterprise ID in the mib is GCOM Technologies, these are either rebranded GCOM or that is just a random enterprise ID:

--      Note that the admin enterprise ID (13464) is used in the sample
--      MIBs.  The customer "must" replace the admin enterprise ID with
--      the registered enterprise identifier for the specific company or
--      product.  The customer must also replace the ADMIN information
--      located in the 'MODULE-IDENTITY' in each sample MIB.
@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

In fact, it seems that they use multiple different mibs, from different origins ... One of them is indeed GBN according to the mib filenames.
But as only very few OIDs are available, I suggest to stick with one OS (and handle the different OIDs in it) instead of creating as many OSes as devices from this vendor...

Show resolved Hide resolved LibreNMS/OS/Fs.php Outdated
@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

@murrant whenever you have time to review this, I would suggest we merge it. If new models of this vendor are to be integrated, we'll extend this later.
From my point of view, it looks OK.

- fs
discovery:
- sysObjectID:
- .1.3.6.1.4.1.51134

This comment has been minimized.

Copy link
@murrant

murrant Jan 31, 2019

Member

That is a lot of sysObjectIDs. I'm concerned this OS isn't the right scope. OS should be defined per OS/MIB set, not per vendor.

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Jan 31, 2019

Author Contributor

OK. I don't really understand the mess they did with so many sysObjectIDs. For the moment we have 2 mib groups (GBN* and SWITCH) so we will start with 2 OSes grouped in "fs".

This comment has been minimized.

Copy link
@murrant

murrant Feb 7, 2019

Member

I'm pretty sure all of the Fiberstore equipment is just rebranded oem equipment.

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Feb 7, 2019

Author Contributor

That would make sense ... Anyway, I'll still do that split ASAP.

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Feb 10, 2019

Author Contributor

Split done. Right now, 2 groups.

@PipoCanaja PipoCanaja changed the title Fiberstore device support Fiberstore device support (WIP) Jan 31, 2019

@PipoCanaja PipoCanaja force-pushed the PipoCanaja:FS branch from d2372ce to 4fb8fee Feb 9, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Feb 10, 2019

Looking pretty close. Just one thing I commented on. Also curious as to why you picked fs-other.

PipoCanaja added some commits Feb 10, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2019

I ended up with fs-gbn and fs-switch according to the mib they follow. You should not find any fs-other anymore in the current status of the PR.

@PipoCanaja PipoCanaja changed the title Fiberstore device support (WIP) FS.COM (Fiberstore) 'GBN' and 'SWITCH' devices support Feb 10, 2019

@murrant murrant merged commit 7e18a07 into librenms:master Feb 10, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:FS branch Mar 7, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

FS.COM (Fiberstore) 'GBN' and 'SWITCH' devices support (librenms#9734)
* Basic Support for Fiberstore devices

* Basic Support for Fiberstore devices

* mib files

* sysObjectID added

* mibs added

* MIB corrections + CPU discovery + version and SN

* CodeClimate + mempools

* CodeClimate + mempools

* mempools

* 5800

* testdata

* 5800

* tests

* mempools for 5800

* CodeClimate

* CodeClimate

* Cleaning and comments

* Tests for 5800

* CodeClimate

* Update Fs.php

* init processors[]

* optimized logo

* optimized logo

* optimized logo

* optimized logo

* split FS devices

* split FS devices

* split FS devices - tests

* split FS devices - class

* split FS devices - class

* split FS devices - tests

* removing un-necessry condition

* text and comments

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.