Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Device: Bluecat Networks appliances #9758

Merged
merged 4 commits into from Feb 3, 2019

Conversation

Projects
None yet
4 participants
@ipptac
Copy link
Contributor

commented Jan 29, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Bluecat Networks IPAM Appliance Support
Default Linux detection already in LibreNMS for CPU/Memory/Disk. Have added OS detection for appliance logos along with DNS, DHCP, NTP sensor monitoring for alerting integration when the following -

  • bcnHaServiceStatus
  • bcnDhcpv4SerOperState
  • bcnDnsSerOperState
  • bcnNtpSerOperState

This is useful when the platform is deployed in an XHA environment for DHCP failover.

bcn-sensors

Pre-commit checks out.

`andy@libredev00:/opt/librenms# ./scripts/pre-commit.php
Only checking os: bluecatnetworks
Running unit tests...
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

...... 6 / 6 (100%)

Time: 1.71 seconds, Memory: 28.00MB

OK (6 tests, 1181 assertions)
Style check skipped.
Lint check skipped.
Tests ok, submit away :)
`

@CLAassistant

This comment has been minimized.

Copy link

commented Jan 29, 2019

CLA assistant check
All committers have signed the CLA.

@TheGreatDoc
Copy link
Contributor

left a comment

You commited lot of unrelated files changes (the .gitignore permissions ones)

@ipptac

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

Hi @TheGreatDoc, sorry about that. How best to remove them, please?

@murrant

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

git magic: https://stackoverflow.com/questions/12481639/remove-files-from-git-commit
Or, you could close this PR and try again :)

@ipptac

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

@murrant Thanks for the comment. I've already removed the files, and re-submitted. Anything else wrong here now?

@TheGreatDoc

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

@ipptac I've converted it to yaml. Also added the replication status.

I've also created 2 state sensor groups. HA Cluster Status and HA Services Status

Please, test it.

Files has been removed

@ipptac

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

@TheGreatDoc Thanks. LGTM. Removed the PHP and added the YAML file. It checks out on all four of our lab boxes.

@TheGreatDoc

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

@ipptac does the Replication State works? It wasnt in the snmprec file so I couldnt check it

@ipptac

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

@TheGreatDoc Not queryable, despite being in the MIB -

root@libredev00:/opt/librenms# snmpwalk -v 2c -c bcnCommunityV2C labbdds01.lab.ipperf.local .1.3.6.1.4.1.13315.3.1.5.2.1.2
iso.3.6.1.4.1.13315.3.1.5.2.1.2 = No Such Object available on this agent at this OID

We're also following up with the vendor about the HA status (failed(8)) on the running Virtual IP of the XHA cluster, as it shouldn't be returning that, however this doesn't invalidate the submission.

@TheGreatDoc
Copy link
Contributor

left a comment

LGTM

@TheGreatDoc TheGreatDoc merged commit db48880 into librenms:master Feb 3, 2019

5 of 6 checks passed

codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.