Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dantel WebMon Device Support #9767

Merged
merged 3 commits into from Mar 5, 2019

Conversation

Projects
None yet
4 participants
@network-guy
Copy link
Contributor

commented Jan 31, 2019

Support for Dantel WebMon units. Currently only polls temperature and humidity for the onboard sensors.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Dantel WebMon Support
Webmon tep discovery changes

Fix Code Climate Issues

@network-guy network-guy force-pushed the network-guy:dantel-webmon branch from 0fcc9d0 to 637a25f Jan 31, 2019

@kkrumm1 kkrumm1 added the Device 🖥 label Jan 31, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2019

Hello,
Thanx for your PR. Could you please also run ./scripts/save-test-data.php to create the json file reference, that will be later use for non regression tests.
PipoCanaja

@network-guy

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2019

Requested changes have been made.

@murrant
Copy link
Member

left a comment

Looks good overall, just a few tweaks.

Show resolved Hide resolved includes/discovery/sensors/temperature/webmon.inc.php Outdated
Show resolved Hide resolved includes/polling/os/webmon.inc.php Outdated
Show resolved Hide resolved includes/discovery/sensors/humidity/webmon.inc.php Outdated

@murrant murrant requested a review from PipoCanaja Feb 22, 2019

Stale review

@murrant murrant merged commit 65fba42 into librenms:master Mar 5, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Hi @network-guy

Another LibreNMS user runs WebMon devices, and seems to have a different card in Slot 1. Your implementation suppose that temperature and humidity, which is not always the case.
I'll propose a new implementation using "count" sensor (a neutral one) in order to try to match all type of cards in all slots.

@PipoCanaja PipoCanaja referenced this pull request Mar 16, 2019

Merged

Improved support for Dantel Webmon #9977

1 of 1 task complete

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Dantel WebMon Device Support (librenms#9767)
* Dantel WebMon Support

Webmon tep discovery changes

Fix Code Climate Issues

* WebMon - Move MIB to folder and create json reference

* Minor changes to Webmon polling

@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.