Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGP Session down rule: add conditions for bgp admin status = stop #9773

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@Cormoran96
Copy link
Contributor

commented Feb 4, 2019

I propose this change so that bgp sessions down volunteer is not on alert

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

I propose this change so that bgp sessions down volunteer is not on alert

Add conditions for bgp admin status = stop
I propose this change so that bgp sessions down volunteer is not on alert
@murrant

murrant approved these changes Feb 4, 2019

Copy link
Member

left a comment

LGTM
Should also work for broken bgpPeers implementations, nice job.

@murrant murrant merged commit 0b1c737 into librenms:master Feb 4, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant changed the title Add conditions for bgp admin status = stop BGP Session down rule: add conditions for bgp admin status = stop Feb 4, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Apr 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.