Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration fixes #9776

Merged
merged 4 commits into from Feb 5, 2019

Conversation

Projects
None yet
1 participant
@murrant
Copy link
Member

commented Feb 4, 2019

Allow lnms migrate to work :)
Don't let the web installer continue if migration fails
Fix validation to work properly and be a little more informative.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the Bug 🐞 label Feb 4, 2019

@murrant murrant merged commit e5eb32c into librenms:master Feb 5, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:migration-fixes branch Feb 5, 2019

sjtarik added a commit to sjtarik/librenms that referenced this pull request Feb 19, 2019

Migration fixes (librenms#9776)
* add migrate:install to lnms, but hide it

* Fix Database migration validation

* remove extra import

* Don't allow install to continue if db build fails

@lock lock bot locked as resolved and limited conversation to collaborators Apr 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.