Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port exists check in eventlog #9778

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@CoMMyz
Copy link
Contributor

commented Feb 5, 2019

Check if port exists before getting the label as some ports may have events but then removed and this can break eventlog page.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Port exists check in eventlog
Check if port exists before getting the label as some ports may have events but then removed and this can break eventlog page.
@CLAassistant

This comment has been minimized.

Copy link

commented Feb 5, 2019

CLA assistant check
All committers have signed the CLA.

@murrant

murrant approved these changes Feb 5, 2019

Copy link
Member

left a comment

Thanks :)

@murrant murrant merged commit 2b4d8fc into librenms:master Feb 5, 2019

5 of 6 checks passed

codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the Bug 🐞 label Feb 5, 2019

@CoMMyz CoMMyz deleted the CoMMyz:patch-1 branch Feb 6, 2019

sjtarik added a commit to sjtarik/librenms that referenced this pull request Feb 19, 2019

Port exists check in eventlog (librenms#9778)
Check if port exists before getting the label as some ports may have events but then removed and this can break eventlog page.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.