Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JunOS: Added Virtual Chassis Member Role Sensor #9783

Merged
merged 4 commits into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@ipptac
Copy link
Contributor

commented Feb 5, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Added VC member detection YAML code to the end of junos.yaml file. This provides -

screenshot 2019-02-05 at 21 27 25

oid: jnxVirtualChassisMemberTable
value: jnxVirtualChassisMemberRole
num_oid: '.1.3.6.1.4.1.2636.3.40.1.4.1.1.1.3.{{ $index }}'
descr: jnxVirtualChassisMemberSerialnumber

This comment has been minimized.

Copy link
@TheGreatDoc

TheGreatDoc Feb 6, 2019

Contributor

Maybe instead of Serialnumber as descr you could use another one more identificative? Just a question more than a review. Maybe jnxVirtualChassisMemberAlias?

This comment has been minimized.

Copy link
@ipptac

ipptac Feb 6, 2019

Author Contributor

Hi @TheGreatDoc, I decided on jnxVirtualChassisMemberSerialnumber as from a replacement perspective when a remote FE is on-site to replace a device, there's nothing clearer than the serial number with which to refer against. Also, it isn't always guaranteed that the EX has the jnxVirtualChassisMemberAlias set whereas the serial number is always present.

@TheGreatDoc

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

ipptac and others added some commits Feb 8, 2019

@TheGreatDoc

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

@ipptac I was going to merge this when I noticed something odd in master branch. Let me check with murrant and will be merged soon.

@TheGreatDoc
Copy link
Contributor

left a comment

LGTM

@TheGreatDoc TheGreatDoc changed the title Added Virtual Chassis Member Role Sensor JunOS: Added Virtual Chassis Member Role Sensor Feb 11, 2019

@TheGreatDoc TheGreatDoc merged commit 25954cc into librenms:master Feb 11, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@lock lock bot locked as resolved and limited conversation to collaborators Apr 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.