Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unexpected os when loading yaml #9790

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

commented Feb 6, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the Bug 🐞 label Feb 6, 2019

@murrant murrant merged commit 8d3a3c9 into librenms:master Feb 6, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:missing-file branch Feb 6, 2019

@daveo918

This comment has been minimized.

Copy link

commented Feb 7, 2019

Thank you so much @murrant, awesome response to this issue. We passing all checks and can save thresholds and alert rules again!

@murrant

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

@daveo918 thanks, still not sure how you managed to break it 😉

sjtarik added a commit to sjtarik/librenms that referenced this pull request Feb 19, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Apr 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.