Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional info for Postgres application #9791

Merged
merged 2 commits into from Feb 7, 2019

Conversation

Projects
None yet
3 participants
@SirMaple
Copy link
Contributor

commented Feb 7, 2019

Added the directions for installing the Nagios check check_postgres.pl for the Postgres Application.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Update Applications.md
Added the directions for installing the Nagios check check_postgres.pl for the Postgres Application.
@CLAassistant

This comment has been minimized.

Copy link

commented Feb 7, 2019

CLA assistant check
All committers have signed the CLA.

@murrant

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

Why have you chosen to build it from git instead of downloading the release version or the packaged version?

Perhaps just a link to the webpage is enough? https://bucardo.org/check_postgres/ or https://github.com/bucardo/check_postgres

@SirMaple

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

I built it from git as that's what I found on the forums https://community.librenms.org/t/postgres-snmp-application/3133 and it worked for me.

I would agree that a link would be better.

Update Applications.md
Remove git building instructions and simply adding a link to https://github.com/bucardo/check_postgres.
@murrant

murrant approved these changes Feb 7, 2019

@murrant murrant merged commit 368e2c4 into librenms:master Feb 7, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant changed the title Update Applications.md Additional info for Postgres application Feb 7, 2019

@SirMaple SirMaple deleted the SirMaple:patch-1 branch Feb 7, 2019

sjtarik added a commit to sjtarik/librenms that referenced this pull request Feb 19, 2019

Update Applications.md (librenms#9791)
* Update Applications.md

Added the directions for installing the Nagios check check_postgres.pl for the Postgres Application.

* Update Applications.md

Remove git building instructions and simply adding a link to https://github.com/bucardo/check_postgres.

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Update Applications.md (librenms#9791)
* Update Applications.md

Added the directions for installing the Nagios check check_postgres.pl for the Postgres Application.

* Update Applications.md

Remove git building instructions and simply adding a link to https://github.com/bucardo/check_postgres.

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.