Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canopsis transport #9795

Merged
merged 3 commits into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@aylham
Copy link
Contributor

commented Feb 8, 2019

Fixing the Canopsis Transport and relatable documentation to make it compliant with version 3.9.0
DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant

This comment has been minimized.

Copy link

commented Feb 8, 2019

CLA assistant check
All committers have signed the CLA.

@@ -10,7 +10,7 @@ path: blob/master/doc/

rpm -Uvh https://mirror.webtatic.com/yum/el7/webtatic-release.rpm

yum install composer cronie fping git httpd ImageMagick jwhois mariadb mariadb-server mtr MySQL-python net-snmp net-snmp-utils nmap php72w php72w-cli php72w-common php72w-curl php72w-gd php72w-mbstring php72w-mysqlnd php72w-process php72w-snmp php72w-xml php72w-zip python-memcached rrdtool
yum install composer cronie fping git httpd ImageMagick jwhois mariadb mariadb-server mtr MySQL-python net-snmp net-snmp-utils nmap php72w php72w-cli php72w-common php72w-curl php72w-gd php72w-mbstring php72w-mysqlnd php72w-process php72w-snmp php72w-xml php72w-zip python-memcached rrdtool php72w-bcmath

This comment has been minimized.

Copy link
@murrant

murrant Feb 8, 2019

Member

Why have you added bcmath?

This comment has been minimized.

Copy link
@aylham

aylham Feb 9, 2019

Author Contributor

Because without it I got the following error : production.ERROR: Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined function PhpAmqpLib\Wire\bcmod() in /opt/librenms/vendor/php-amqplib/php-amqplib/PhpAmqpLib/Wire/AMQPWriter.php:36

But as it seems to be AMQP specific maybe it's overkill to add it to basic install.

This comment has been minimized.

Copy link
@murrant

murrant Feb 10, 2019

Member

Huh, it is used by amqp... maybe not the default install docs but somewhere else.

@murrant
Copy link
Member

left a comment

Looks good, thanks.

@murrant murrant merged commit cf17016 into librenms:master Feb 11, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Canopsis transport (librenms#9795)
* Change in the Canopsis transport to make it 3.9.0 compliant and link to
the new documentation

* Add missing php72 module on Centos

* Fixing documentation for AMQP based tranport outside of the main doc

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.