Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Alertmanager transport #9807

merged 1 commit into from Feb 12, 2019


None yet
2 participants
Copy link

commented Feb 12, 2019

This is a fix for 9637 pull request, which offered Alertmanager transport integration. What we did achieve is correct processing of resolved alerts - in my playground it was only a coincidence they were processed normally. After setting this up in a pre-prod environment, we saw alert resolutions are only processed after timeout in Alertmanager itself.

This fix changes JSON layout according to this article:

The only thing I remain uncertain with - if date function use is correct considering movement to Laravel.


Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.


If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.


This comment has been minimized.

Copy link

commented Feb 12, 2019

The date function is fine. we have Carbon, but for simple things like this date() is better.

@murrant murrant merged commit c0aea75 into librenms:master Feb 12, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Inspection Summary
Node: analysis
Travis CI - Pull Request Build Passed
WIP Ready for review
license/cla Contributor License Agreement is signed.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.