Fixed apc powerbar phase limit discovery for AP7852 firmware: 2.7.3 #981

Merged
merged 6 commits into from May 13, 2015

Projects

None yet

4 participants

@zarya
Contributor
zarya commented May 12, 2015

No description provided.

@laf
Member
laf commented May 12, 2015

@paulgear / @f0o

Would one of you mind taking a quick look over this.

I'm more happy with how this patch is now, I initially thought this might cause data loss but it appears not as the rrd filenames are the same. It does an if check against the limits returned, according to the MIB for the APC units, -1 means no banks exist so this looks like we should be doing it this way.

the initial commit isn't the best way to approach this imho so I asked @zarya to change it.

Thoughts?

@f0o
Member
f0o commented May 13, 2015

Looks good to me.

@paulgear
Member

It looks OK, and is likely to only have a very limited effect. I'm guessing @zarya the only one running these particular devices? (Can we find that out from stats.librenms.org?)

@laf
Member
laf commented May 13, 2015

We should have been able to but alas it's not been logging that for some reason :/

@laf laf merged commit 0c4ff03 into librenms:master May 13, 2015

1 check passed

Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment