Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PHPMailer 6.0 (PHP 7.3 support) #9818

Merged
merged 2 commits into from Feb 15, 2019

Conversation

Projects
None yet
2 participants
@felici
Copy link
Contributor

commented Feb 13, 2019

PCRE is changed in PHP 7.3 which broke the email validation in PHPMailer 5.2 causing issues and it's also end-of-life since December 31st 2018.

More info here.

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Looks good, need to test it to make sure it doesn't break anything.

@murrant
Copy link
Member

left a comment

LGTM, thanks!

@murrant murrant merged commit 942dc65 into librenms:master Feb 15, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the Bug 🐞 label Mar 4, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.