Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging too much #9824

Merged
merged 2 commits into from Feb 14, 2019

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

commented Feb 14, 2019

Web servers are not running as the librenms user, so they are not capable of using daily rotation by Laravel yet...
Also mark all the files in config as non-editable

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fix logging
Also mark all the files in config as non-editable

@murrant murrant added the Bug 🐞 label Feb 14, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

May be we could also add how to change in .env the level from debug to warning for instance.

@murrant murrant changed the title Fix logging too much WIP Fix logging too much Feb 14, 2019

@murrant murrant changed the title WIP Fix logging too much Fix logging too much Feb 14, 2019

@murrant

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2019

@PipoCanaja I got things a little mixed up in the Laravel PR. The file logging SHOULD have been error and the stderr should have been debug (stderr is set when debug is enabled on the cli)

Should be correct now.

@PipoCanaja
Copy link
Contributor

left a comment

Looks good

@murrant murrant merged commit 108348e into librenms:master Feb 14, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-logging branch Feb 14, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.