Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIPU MyPowerOS: CPU, Memory, expanded detection #9825

Merged
merged 2 commits into from Feb 15, 2019

Conversation

Projects
None yet
3 participants
@TheGreatDoc
Copy link
Contributor

commented Feb 14, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

This is for https://community.librenms.org/t/add-support-for-maipu/7207

Thanks to @deddey who did all the work. I've only PR'ed it (and modified a little to make it more efficient)

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

Hello @TheGreatDoc
Are the permissions set to 755 on purpose on 2 of the files ? includes/definitions/mypoweros.yaml and the snmprec ?
++ PipoCanaja

@TheGreatDoc

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

@PipoCanaja No, they are not.... 🤦‍♂️

I'll fix later or feel free to do it yourself.

@murrant murrant changed the title New OS: MAIPU MyPowerOS MAIPU MyPowerOS CPU and Memory Feb 15, 2019

@murrant murrant changed the title MAIPU MyPowerOS CPU and Memory MAIPU MyPowerOS: CPU and Memory Feb 15, 2019

@murrant murrant changed the title MAIPU MyPowerOS: CPU and Memory MAIPU MyPowerOS: CPU, Memory, expanded detection Feb 15, 2019

@murrant
Copy link
Member

left a comment

LGTM

@murrant murrant merged commit 6ea0e72 into librenms:master Feb 15, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@TheGreatDoc TheGreatDoc deleted the TheGreatDoc:device-maipu-mypoweros branch Feb 17, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Apr 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.