Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to download config as text file #9831

Closed

Conversation

Projects
None yet
4 participants
@VirTechSystems
Copy link
Contributor

VirTechSystems commented Feb 15, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant

This comment has been minimized.

Copy link
Member

murrant commented Feb 15, 2019

@VirTechSystems I like the idea, but this is very insecure.
Two options, use javascript https://stackoverflow.com/questions/3665115/create-a-file-in-memory-for-user-to-download-not-through-server
Re-write to use Laravel https://laravel.com/docs/5.7/responses#file-downloads and don't send the file to the server via a form, you need to check the user has permission and re-fetch it from oxidized, then send it for download.

@murrant

This comment has been minimized.

Copy link
Member

murrant commented Feb 15, 2019

The second option would be more compatible.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

PipoCanaja commented Mar 29, 2019

Hi @VirTechSystems
Any news on this ? Any ongoing developpement ? If yes or if you plan to, could you please put this PR in WIP mode ?
Thanx

@VirTechSystems

This comment has been minimized.

Copy link
Contributor Author

VirTechSystems commented Apr 1, 2019

No, unfortunately not. I'm not really familiar with laravel and haven't been able to figure out how to implement what you're looking for in any way that makes sense.

You can close this out, if you want.

@laf laf closed this Apr 9, 2019

@laf

This comment has been minimized.

Copy link
Member

laf commented Apr 9, 2019

Thanks for contributing though @VirTechSystems. If we can help in anyway let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.