Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added power and fan sensors to VRP #9838

Merged
merged 22 commits into from Feb 22, 2019

Conversation

Projects
None yet
3 participants
@jozefrebjak
Copy link
Contributor

commented Feb 18, 2019

Added

image

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

jozefrebjak added some commits Feb 18, 2019

@jozefrebjak jozefrebjak changed the title WIP Added power and fan sensors to VRP Added power and fan sensors to VRP Feb 18, 2019

@@ -119,4 +119,35 @@ modules:
index: '{{ $index }}'
skip_values: -1
divisor: 1000000

load:
data:

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Feb 18, 2019

Contributor

You probably want "fan" and not "load" here :)

This comment has been minimized.

Copy link
@jozefrebjak

jozefrebjak Feb 18, 2019

Author Contributor

there is value in percentage instead of rpm, so we cant use fan category.

This comment has been minimized.

Copy link
@jozefrebjak

jozefrebjak Feb 18, 2019

Author Contributor

image

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Feb 18, 2019

Contributor

If you have the full speed in an OID, you can do the math in yaml and convert to the proper unit (RPM). If you don't, then you should probably use count and a group to explain what it is.

This comment has been minimized.

Copy link
@jozefrebjak

jozefrebjak Feb 18, 2019

Author Contributor

I found some of the maximum speed of the fan, but there is more than one module of fan, with different speeds, and i cant find an oid with that information for now. For VRP this will be the very first load sensor, and look at the picture in description i believe that its clear about what is going on. I can add group, this is not a problem.

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Feb 18, 2019

Contributor

If it is not exactly what the load class is for, then we must use "count" which is the only generic class we have. Then groups and name of the sensor will explain the user what it is.

This comment has been minimized.

Copy link
@murrant

murrant Feb 19, 2019

Member

Can't use count here. You could add a new sensor for this, otherwise, drop it.

This comment has been minimized.

Copy link
@jozefrebjak

jozefrebjak Feb 22, 2019

Author Contributor

@murrant i dont know how to add new sensor, so i dropped load of the fan.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

Hi @jozefrebjak

Could you create a new variant instead of changing the existing one for tests ? Your device is not the same as the existing one in tests.

Thx

@jozefrebjak

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

Hi @jozefrebjak

Could you create a new variant instead of changing the existing one for tests ? Your device is not the same as the existing one in tests.

Thx

OK I will make another test data

jozefrebjak added some commits Feb 18, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

You should revert the old snmprec but recompute (save-test-data) the json in case necessary.

jozefrebjak added some commits Feb 22, 2019

Resolved

@murrant murrant merged commit 99c8dbd into librenms:master Feb 22, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja referenced this pull request Feb 22, 2019

Merged

VRP: add fan description to hwEntityFanState #9863

1 of 1 task complete

@murrant murrant added the Device 🖥 label Mar 4, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Added power and fan sensors to VRP (librenms#9838)
* added power and fan sensors to vrp

* Update vrp.yaml

* Update vrp.yaml

* Update vrp_5720.snmprec

* Update vrp_5720.json

* Delete vrp_5720.snmprec

* Delete vrp_5720.json

* revert old snmprec file for 5720

* revert old json file for vrp 5720

* Create vrp_5720_32x.snmprec

* Create vrp_5720_32x.json

* Update vrp_5720_32x.snmprec

* Update vrp_5720_32x.json

* Update vrp_5720_32x.snmprec

* Update vrp_5720_32x.json

* Update vrp_5720_32x.snmprec

* Update vrp.yaml

* Delete vrp_5720_32x.json

* Delete vrp_5720_32x.snmprec

* Add files via upload

* Add files via upload

* Update vrp_5720.json

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.