Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syslog hostname translation broken #9839

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@TylerSweet
Copy link
Contributor

commented Feb 18, 2019

For some reason, this is now broken. Accessing the array this way fixes it. I suspect it has something to do with the periods in the host names

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

For some reason, this is now broken. Accessing the array this way fix…
…es it. I suspect it has something to do with the periods in the host names
@murrant

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

Good catch, would cause an error if the index does not exist. But error check is disabled in legacy code.

@murrant murrant merged commit 06d61fc into librenms:master Feb 19, 2019

4 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@TylerSweet TylerSweet deleted the TylerSweet:syslog_fixes branch Feb 19, 2019

@murrant murrant added the Bug 🐞 label Mar 4, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

For some reason, this is now broken. Accessing the array this way fix…
…es it. I suspect it has something to do with the periods in the host names (librenms#9839)

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.