Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug display of rrdtool command #9846

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
3 participants
@Anthony25
Copy link
Contributor

commented Feb 19, 2019

Use the function rrdtool_build_command to display the correct debug data

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fix path in rrdtool show command with rrdcached
Sanitize the command before printing it
@CLAassistant

This comment has been minimized.

Copy link

commented Feb 19, 2019

CLA assistant check
All committers have signed the CLA.

@PipoCanaja
Copy link
Contributor

left a comment

Tested and LGTM

@PipoCanaja PipoCanaja changed the title Fix path in rrdtool show command with rrdcached Fix debug display of rrdtool command Feb 20, 2019

@PipoCanaja PipoCanaja merged commit 914531a into librenms:master Feb 21, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@lock lock bot locked as resolved and limited conversation to collaborators Apr 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.