Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graphs for ASA announcing all interfaces in type l2vlan (by default filtered) #9849

Merged
merged 2 commits into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@PipoCanaja
Copy link
Contributor

commented Feb 20, 2019

Cisco ASA announces all its interfaces in l2vlan type (at least in multi-context mode). Or by default these are ignored in graphs (which is good generally speaking). Which gives an empty errored device_bits overall graph for each ASA contexts.

In order to avoid this, this PR add a condition to ignore the l2vlan filtering for ASA.

The other option would be to create a filter list "per os" but it seems a little bit overkill only for this ASA issue.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja changed the title Bug - Fix graphs for ASA announcing all interfaces in l2vlan Fix graphs for ASA announcing all interfaces in type l2vlan (by default filtered) Feb 20, 2019

@PipoCanaja PipoCanaja added this to the 1.50 milestone Mar 1, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

Why filter it only in the graphs? Are the interfaces useful elsewhere? You could just filter the ports completely by updating the OS yaml.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

In fact, I want to "unfilter" them in the graphs.
Polling works beautifully but because of the filtering, they are not included in the aggregation graph on device page, graph which ends up beeing "Error drawing graph" (because all RRDs are filtered, so nothing remains).
I don't think we can do anything in the YAML (cause this part works perfectly).

@murrant
Copy link
Member

left a comment

Still unsure what you are doing here, but I trust you :)

@PipoCanaja PipoCanaja merged commit be58ec3 into librenms:master Mar 13, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:asa-graphs branch Mar 13, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fixed overview graph on Cisco ASA announcing all interfaces in type l…
…2vlan (by default filtered) (librenms#9849)

* Fix ASA announcing all interfaces in l2vlan
* Fix ASA announcing all interfaces in l2vlan

@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.