Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Moxa EDS-G512E-8PoE #9857

Merged
merged 30 commits into from Mar 5, 2019

Conversation

Projects
None yet
3 participants
@priiduonu
Copy link
Contributor

commented Feb 21, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

priiduonu added some commits Feb 21, 2019

@label-actions

This comment has been minimized.

Copy link

commented Feb 24, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2019

And following the add of the tests, you should check on Travis CI tests, they must succeed in order to merge the changes.

@PipoCanaja
Copy link
Contributor

left a comment

Travis CI checks must succeed.

priiduonu added some commits Feb 25, 2019

Merge pull request #1 from priiduonu/master
Add Moxa EDS-G512E-8PoE test data
@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Thanx, It is much better, but it seems that your master is not up to date. You should keep master in sync with librenms master and only work in a branch for patches.
In that case, these would ensure that your patch is running against the last version:

git checkout master
git pull origin master
git checkout newdevice/moxa-edsg512e8poe
git rebase master
git push origin newdevice/moxa-edsg512e8poe

PipoCanaja

priiduonu and others added some commits Feb 21, 2019

Merge pull request #2 from priiduonu/revert-1-master
Revert "Add Moxa EDS-G512E-8PoE test data"
Merge branch 'newdevice/moxa-edsg512e8poe' of github.com:priiduonu/li…
…brenms into newdevice/moxa-edsg512e8poe

Stale review

@murrant

murrant approved these changes Mar 5, 2019

@murrant murrant merged commit 489666a into librenms:master Mar 5, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@priiduonu priiduonu deleted the priiduonu:newdevice/moxa-edsg512e8poe branch Mar 11, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Add support for Moxa EDS-G512E-8PoE (librenms#9857)
* Add support for MOXA EDSG512E8-PoE

* Add support for MOXA EDS-G512E-8PoE

* Add support for MOXA EDS-G512E-8PoE

* Remove whitespace

* Create MOXA-EDSG512E8POE-MIB

* Delete MOXA-EDSG512E8POE-MIB

* Create MOXA-EDSG512E8POE-MIB

* Delete MOXA-EDSG512E8POE-MIB

* Create MOXA-EDSG512E8POE-MIB

* Update moxa-etherdevice.yaml

* Create moxa-etherdevice_edsg512epoe.snmprec

* Create moxa-etherdevice_edsg512epoe.json

* Add support for MOXA EDSG512E8-PoE

* Add support for MOXA EDS-G512E-8PoE

* Add support for MOXA EDS-G512E-8PoE

* Remove whitespace

* Create MOXA-EDSG512E8POE-MIB

* Delete MOXA-EDSG512E8POE-MIB

* Create MOXA-EDSG512E8POE-MIB

* Delete MOXA-EDSG512E8POE-MIB

* Create MOXA-EDSG512E8POE-MIB

* Update moxa-etherdevice.yaml

* Revert "Add Moxa EDS-G512E-8PoE test data"

* Add test data for Moxa EDS-G512E-8PoE

* Removed whitespace

* Update moxa-etherdevice_edsg512epoe.json

* Update moxa-etherdevice_edsp510a8poe.json

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.