Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRP: add fan description to hwEntityFanState #9863

Merged
merged 2 commits into from Mar 1, 2019

Conversation

Projects
None yet
3 participants
@PipoCanaja
Copy link
Contributor

commented Feb 22, 2019

Very short addon to #9838

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

but I cannot generate the testdata for the device @jozefrebjak used, so Travis won't be happy.
@jozefrebjak : could you rerun collect_snmp_data and save_test_data with this patch applied and commit the new files to this PR ?

Thanx

@jozefrebjak

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2019

@PipoCanaja yes i can but on monday, because my testing install is running on my work computer as a vm.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

Hi @jozefrebjak ,
Would you have time to get the testdata ?
Thx
PipoCanaja

@jozefrebjak

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

@PipoCanaja i got them, how i can add them to your PR ?

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

@jozefrebjak Please attach the file to this PR as a attachement to a comment. That's the easiest. I'll grab it and push it.
Thanx

@jozefrebjak

This comment has been minimized.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

Travis CI is happy now. Thanx for your help @jozefrebjak !
@librenms/reviewers : ready for merge.

@PipoCanaja PipoCanaja added this to the 1.49 milestone Feb 28, 2019

@murrant

murrant approved these changes Mar 1, 2019

@murrant murrant merged commit e82f1fc into librenms:master Mar 1, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:vrp-fans-detail branch Mar 7, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

VRP: add fan description to hwEntityFanState (librenms#9863)
* VRP: add fan description to hwEntityFanState

* tests

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.