Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] edgeswitch v1.9 os detection #9868

Merged
merged 2 commits into from Feb 25, 2019

Conversation

Projects
None yet
3 participants
@crcro
Copy link
Contributor

commented Feb 24, 2019

EdgeSwitch v1.9 version could not be detected due to sysObjectID change from .1.3.6.1.4.1.4413 to .1.3.6.1.4.1.41112

before:
screen shot 2019-02-24 at 9 47 29 pm

after:
screen shot 2019-02-24 at 9 46 50 pm

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit ee76057 into librenms:master Feb 25, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant added the Device 🖥 label Mar 4, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fixed edgeswitch v1.9 os detection (librenms#9868)
* fix edgeswitch os defitions for next os version

* cleanup

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.