Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup of device page #9870

Open
wants to merge 27 commits into
base: master
from

Conversation

Projects
None yet
@crcro
Copy link
Contributor

commented Feb 24, 2019

A follow-up on an older "task" to cleanup the UI.

screen shot 2019-02-25 at 12 05 05 am

screen shot 2019-02-25 at 12 04 43 am

screen shot 2019-02-25 at 12 04 32 am

screen shot 2019-02-25 at 12 04 21 am

screen shot 2019-02-25 at 12 04 11 am

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

crcro and others added some commits Feb 24, 2019

Update Example-Hardware-Setup.md
Added the specs of my setup.
Merge pull request #9872 from SirMaple/patch-1
Added new install to example hardware setup
@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Hello @crcro
I have a doubt concerning the use of inline styles. Makes it difficult to maintain. @librenms/reviewers , any advices on this ?

@crcro

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

i will put them into css files at the end

esundberg and others added some commits Feb 25, 2019

Added Perle OS Support for IOLAN SCS (#9866)
* Sync Git to Master

* OS Support for Perle Terminal Servers. Added via /scripts/new-os.php. Tested on two devices

* There was an existing Perle OS, updated it to include the Perle IOLAN SCS model .1.3.6.1.4.1.1966.12. Removed Files the script created that were no longer needed

* There was an existing Perle OS, updated it to include the Perle IOLAN SCS model .1.3.6.1.4.1.1966.12. Removed Files the script created that were no longer needed. Round 2

* Update exiting includes/definitions/perle.yaml to catch all device by Perle. Removed the .gitignore files from the branch

* Git Add includes/definitions/perle.yaml helps

* Empty file not allowed in YAML verification

* restore missing files

* restore missing files

* restore missing files

* Restore the sysDescr

The existing testdata relies on this, as sysObjectID is not collected
Fixed edgeswitch v1.9 os detection (#9868)
* fix edgeswitch os defitions for next os version

* cleanup
Merge pull request #9886 from PipoCanaja/errorMibPlaceFS
Misplaced mib file when adding FS.COM support
Discovery rcChasPowerSupplyOperStatus for Extreme/Avaya (#9878)
* Update voss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Update voss.yaml

* adding support for vsp9012 and vsp8608

* Add files via upload

* Add files via upload

* Add files via upload

* Delete voss_8608.json

* Delete voss_8608.snmprec

* Delete voss_9012.json

* Delete voss_9012.snmprec

* Add files via upload

* Add files via upload

* Delete voss_vsp-9012.json

* Add files via upload

* Add files via upload

* Add files via upload

* Delete voss_vsp-9012.snmprec

* Add files via upload

* Delete voss_8608.json

* Delete voss_8608.snmprec

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload
Added support for Alpha Comp@s (#9871)
* newdevice: Added support for Alpha Comp@s
http://www.alphainnovations.eu/compas

* fix: Updated state values
state values persist in database, even after deletion of devices.
Not a 100% how to purge them.
create_state_index($state_name, $states) doesn't update the database, if the states have changed

* refactor: comp@s OS state sensor now updated to latest format
Added edgeos hardware info (#9867)
* added hardware info
cleanup os version

* allow minor revision to be larger than 9

* Update edgeos.inc.php

* snmprec

* Create edgeos.json
VRP: add fan description to hwEntityFanState (#9863)
* VRP: add fan description to hwEntityFanState

* tests
add support for sagemcom (#9835)
* adds support for sagemcom

* requested changes

* delete unused variable

* logos

* modules fine tuning

* code style

* Update sagemcom.svg

* Update sagemcom.svg
Fix incorrect icon sometimes (#9887)
* Fix icon finding
Also fix os suggest not loading all OS.

* Fix os that would have missing icon under the new code (and one under the old code)

* forgot icon
Alertmanager fix 2 (#9860)
* Improved Alertmanager transport

* Typo fix

* Fix according to Travis fail
Merge pull request #9895 from githubuserx/develop
docs: fix link missing parenthesis
@crcro

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

screen shot 2019-03-03 at 11 22 42 pm

screen shot 2019-03-03 at 11 22 27 pm

screen shot 2019-03-03 at 11 22 21 pm

screen shot 2019-03-03 at 11 22 15 pm

screen shot 2019-03-03 at 11 22 00 pm

screen shot 2019-03-03 at 11 21 53 pm

screen shot 2019-03-03 at 11 21 42 pm

screen shot 2019-03-03 at 11 21 36 pm

crcro added some commits Mar 4, 2019

fix style in powerdns-recursor.inc.php
rewrote modules.inc.php to avoid repetition
@murrant

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@crcro is this still WIP?

@crcro

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

@murrant ... no, but maybe someone spots something that i forgot

@crcro crcro changed the title [WIP] cleanup of device page cleanup of device page Mar 17, 2019

@laf laf added the WebUI label Apr 9, 2019

@laf

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

If you can put the styles into the central stylesheets like @PipoCanaja mentioned.

Do you have before / after screenshots side by side or top/bottom so we can see the diffs as it's hard to see what's changed.

@laf laf added the User-Pending label Apr 9, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Web files have been moved to includes/html, you will need to update your PR, sorry for the trouble. Let us know if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.