Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added support for Alpha Comp@s #9871

Merged
merged 3 commits into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@cppmonkey
Copy link
Contributor

commented Feb 24, 2019

Added support for the Alpha Comp@s AC/DC monitoring system.

Unfortunately the only way to see if it has switched to battery, is to see the battery discharging (negative current draw).

Our unit doesn't report input voltage...

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@cppmonkey cppmonkey force-pushed the cppmonkey:Alpha-Comp@s branch from 4d2328d to 7c0c187 Feb 24, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Hi @cppmonkey
Seems that your test data is not matching your current code. Is it possible that you did not run ./scripts/save-test-data.php with your last version of code ?
You can check the results in TravicCI and track the issue down.
Bye
PipoCanaja

fix: Updated state values
state values persist in database, even after deletion of devices.
Not a 100% how to purge them.
create_state_index($state_name, $states) doesn't update the database, if the states have changed
@cppmonkey

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

I think I've found the issue.

create_state_index($state_name, $states) doesn't update the database. The states had changed in the includes, but hadn't updated the database.
Is it possible to purge a particular state_name from the database?

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 3c0d0c9 into librenms:master Feb 28, 2019

5 of 6 checks passed

codeclimate 8 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@lock lock bot locked as resolved and limited conversation to collaborators Apr 29, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.