Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery rcChasPowerSupplyOperStatus for Extreme/Avaya voss.inc.php stop working #9878

Merged
merged 27 commits into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@ospfbgp
Copy link
Contributor

commented Feb 25, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@ospfbgp

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

Seems that the fan/powersupply mibs were not discovered for Extreme/Avaya VOSS rcChasFanOperStatus and rcChasPowerSupplyOperStatus when using the raw oid. Changed syntax to use actual RAPID-CITY mib name. Seems to have fixed the issue. This has been broken for awhile and just now discovered it.

@ospfbgp ospfbgp changed the title Update voss.inc.php Discovery of fans and power supplies for Extreme/Avaya voss.inc.php stop working Feb 25, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Hi @ospfbgp

Thanx for your PR ! Any chance you could add test-data so that we can catch it next time such an issue comes appears ? I would suggest you create a new variant for your device.

https://docs.librenms.org/Developing/os/Test-Units/

Thanx
PipoCanaja

ospfbgp added some commits Feb 25, 2019

@ospfbgp

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

I have several vsp for testing and could submit that for several models. I need to add new models anyways. I have done the testing and all looks good in database now.

| 863 | 85 | .1.3.6.1.4.1.2272.1.4.8.1.1.2.1 | rcChasPowerSupplyOperStatus.1 | rcChasPowerSupplyOperStatus | Power Supply 1 |
| 864 | 84 | .1.3.6.1.4.1.2272.1.4.8.1.1.2.1 | rcChasPowerSupplyOperStatus.1 | rcChasPowerSupplyOperStatus | Power Supply 1 |
| 865 | 83 | .1.3.6.1.4.1.2272.1.4.8.1.1.2.1 | rcChasPowerSupplyOperStatus.1 | rcChasPowerSupplyOperStatus | Power Supply 1 |
| 866 | 83 | .1.3.6.1.4.1.2272.1.4.8.1.1.2.2 | rcChasPowerSupplyOperStatus.2 | rcChasPowerSupplyOperStatus | Power Supply 2 |

screen shot 2019-02-25 at 5 56 33 pm

screen shot 2019-02-25 at 5 55 51 pm

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

If you have multiple devices, you can Skip some that are too similar. The idea is to have test data that covers most of the situations. Then the regression tests will do a good job as tracking ... régressions ... on all devices ;)

ospfbgp added some commits Feb 27, 2019

@ospfbgp

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

I have added the .snmprec and .json files for vsp8608 and vsp9012. I have tested and they work fine just need to add support. All vsp platforms are very similar so mibs will be very much alike.

@ospfbgp ospfbgp changed the title Discovery of fans and power supplies for Extreme/Avaya voss.inc.php stop working Discovery rcChasPowerSupplyOperStatus for Extreme/Avaya voss.inc.php stop working Feb 27, 2019

@ospfbgp

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

Let me know if there is anything else I need to do here. I think I have everything in order. I have fixed the issue with power supplies not showing up for the VOSS platform. I have added .snmprec and .json files for vsp8608 and vsp9012.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

We need to have Travis CI happy, until then we cannot merge.
Issue is with tests/data/voss_8608.json for the moment.
For some reason Travis does not find the same things as the file you attached to the PR.
Do you have a clean environnement for tests, matching exactly the PR ?

ospfbgp added some commits Feb 28, 2019

ospfbgp added some commits Feb 28, 2019

@ospfbgp

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

Seems Travis is happy now. The error I was getting "Discovered ports data does not match that found in tests/data/voss_XXXX.json". I had to edit voss_xxxx.snmprec and remove the VLANs, since they are not ports. I had this issue before. All should be happy now. :-)

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

This is weird. More data in snmprec should not have any bad impact. If you run ./scripts/pre-cache -o xxxxxx -v yyyyyy, do you see the same behavior than Travis CI ?
Aside of this issue, this looks good.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 1ea3fdd into librenms:master Feb 28, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@lock lock bot locked as resolved and limited conversation to collaborators Apr 29, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.