Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect icon sometimes #9887

Merged
merged 3 commits into from Mar 2, 2019

Conversation

Projects
None yet
1 participant
@murrant
Copy link
Member

commented Feb 28, 2019

Sometimes the device list would not show the correct icon. (mostly ping only os)
Centralize the code so we can reuse it.

Also fix os suggest not loading all OS.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fix icon finding
Also fix os suggest not loading all OS.

@murrant murrant added the Bug 🐞 label Feb 28, 2019

@murrant murrant added this to the 1.49 milestone Feb 28, 2019

murrant added some commits Feb 28, 2019

@murrant murrant merged commit e677d4b into librenms:master Mar 2, 2019

5 of 6 checks passed

codeclimate 3 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-icon-finding branch Mar 2, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fix incorrect icon sometimes (librenms#9887)
* Fix icon finding
Also fix os suggest not loading all OS.

* Fix os that would have missing icon under the new code (and one under the old code)

* forgot icon

@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.