Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VRP stack member and ports discovery #9891

Merged
merged 2 commits into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@PipoCanaja
Copy link
Contributor

commented Mar 1, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja

This comment was marked as resolved.

Copy link
Contributor Author

commented Mar 1, 2019

(waiting for other VRP PR to be merged before finishing this one and pushing tests)

@PipoCanaja PipoCanaja force-pushed the PipoCanaja:vrp_stack branch from 201c9fb to c5730fa Mar 1, 2019

@PipoCanaja PipoCanaja added this to the 1.50 milestone Mar 1, 2019

PipoCanaja added some commits Mar 1, 2019

@PipoCanaja PipoCanaja force-pushed the PipoCanaja:vrp_stack branch from ba15cb9 to 11c4ff7 Mar 4, 2019

@PipoCanaja PipoCanaja changed the title WIP Added VRP stack member and ports discovery Added VRP stack member and ports discovery Mar 4, 2019

@murrant

murrant approved these changes Mar 5, 2019

@murrant murrant merged commit e17f47a into librenms:master Mar 5, 2019

3 of 4 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:vrp_stack branch Mar 7, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.