Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for power supply on Extreme BOSS switches #9898

Merged
merged 20 commits into from Mar 9, 2019

Conversation

Projects
None yet
3 participants
@ospfbgp
Copy link
Contributor

commented Mar 4, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

ospfbgp added some commits Mar 4, 2019

@ospfbgp

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

I have added support for Extreme BOSS power supplies. I have tested on several different stack sizes. Looks good. I did some testing on the patch with variety of stacks. I have included some screen shots.

screen shot 2019-03-03 at 9 41 25 pm

screen shot 2019-03-03 at 9 38 24 pm

ospfbgp added some commits Mar 4, 2019

@ospfbgp

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

I have added BOSS to beginning of sensor so it can be search easily and match on with alert rules. Here is a snapshot of table sensors.

MariaDB [librenms]> select sensor_index,sensor_type,sensor_descr from sensors where sensor_descr like '%BOSS%';
+---------------------------+--------------------+---------------------------------+
| sensor_index | sensor_type | sensor_descr |
+---------------------------+--------------------+---------------------------------+
| s5ChasComOperState.5.10.0 | s5ChasComOperState | BOSS Unit 1: Temperature Sensor |
| s5ChasComOperState.6.10.0 | s5ChasComOperState | BOSS Unit 1: Internal Fan 1 |
| s5ChasComOperState.6.11.0 | s5ChasComOperState | BOSS Unit 1: Internal Fan 2 |
| s5ChasComOperState.6.12.0 | s5ChasComOperState | BOSS Unit 1: Internal Fan 3 |
| s5ChasComOperState.6.13.0 | s5ChasComOperState | BOSS Unit 1: Internal Fan 4 |
| s5ChasComOperState.5.10.0 | s5ChasComOperState | BOSS Unit 1: Temperature Sensor |
| s5ChasComOperState.6.10.0 | s5ChasComOperState | BOSS Unit 1: Internal Fan 1 |
| s5ChasComOperState.6.11.0 | s5ChasComOperState | BOSS Unit 1: Internal Fan 2 |
| s5ChasComOperState.6.12.0 | s5ChasComOperState | BOSS Unit 1: Internal Fan 3 |
| s5ChasComOperState.6.13.0 | s5ChasComOperState | BOSS Unit 1: Internal Fan 4 |
| s5ChasComOperState.4.10.0 | s5ChasComOperState | BOSS Unit 1: Power Supply 1 |
| s5ChasComOperState.4.11.0 | s5ChasComOperState | BOSS Unit 1: Power Supply 2 |
| s5ChasComOperState.4.10.0 | s5ChasComOperState | BOSS Unit 1: Power Supply 1 |
| s5ChasComOperState.4.11.0 | s5ChasComOperState | BOSS Unit 1: Power Supply 2 |
+---------------------------+--------------------+---------------------------------+
14 rows in set (0.00 sec)

@label-actions

This comment has been minimized.

Copy link

commented Mar 4, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

ospfbgp added some commits Mar 6, 2019

ospfbgp added some commits Mar 6, 2019

@ospfbgp

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

Should be in working order now. Added test data for BOSS ers4950 and ers3510

@murrant

murrant approved these changes Mar 9, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

Nice work

@murrant murrant merged commit eb82a15 into librenms:master Mar 9, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Add support for power supply on Extreme BOSS switches (librenms#9898)
* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.