Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Patton SmartNode OS discovery and polling #9901

Merged
merged 4 commits into from Mar 6, 2019

Conversation

Projects
None yet
3 participants
@PipoCanaja
Copy link
Contributor

commented Mar 4, 2019

Closing issue #8454

capture d ecran 2019-03-04 a 23 09 15

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@TheGreatDoc

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

Nice job 👍

PipoCanaja added some commits Mar 4, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

OK, this time, looks complete. We'll see how the test are going.

@PipoCanaja PipoCanaja referenced this pull request Mar 4, 2019

Closed

Support for new device(s) : Patton SIP-Gateway SN4971 #8454

5 of 5 tasks complete
//PATTON SmartNode
$oids = array(
'hw_release' => '.1.3.6.1.4.1.1768.100.1.3.0',

This comment has been minimized.

Copy link
@TheGreatDoc

TheGreatDoc Mar 5, 2019

Contributor

You are going to hate me... But can you move this array() to []?

Sorry I didnt noticed it before

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Mar 5, 2019

Author Contributor

No problem, I sometimes see those, but usually not :) On its way !

[]
@murrant

murrant approved these changes Mar 6, 2019

@murrant murrant merged commit 9deb00f into librenms:master Mar 6, 2019

5 of 6 checks passed

codeclimate 4 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:PattonSN4971 branch Mar 7, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Added Patton SmartNode OS discovery and polling (librenms#9901)
* Patton SmartNode OS discovery and polling

* mempools

* graphs overs

* []

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.