Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in routeros YAML discovery #9903

Merged
merged 3 commits into from Mar 27, 2019

Conversation

Projects
None yet
3 participants
@PipoCanaja
Copy link
Contributor

PipoCanaja commented Mar 5, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja added the Bug 🐞 label Mar 5, 2019

@TheGreatDoc

This comment has been minimized.

Copy link
Contributor

TheGreatDoc commented Mar 5, 2019

I may be wrong, but this fix (which is good) will delete historical data as the index changed.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

PipoCanaja commented Mar 5, 2019

Sounds right. We should probably inform the users in that case.

@PipoCanaja PipoCanaja self-assigned this Mar 15, 2019

PipoCanaja added some commits Mar 5, 2019

@PipoCanaja PipoCanaja force-pushed the PipoCanaja:typo-routeros branch from b0b01c7 to e054de1 Mar 19, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

PipoCanaja commented Mar 19, 2019

Rebase + notification.css done. Can be merged today @TheGreatDoc. Bye

@TheGreatDoc

This comment has been minimized.

Copy link
Contributor

TheGreatDoc commented Mar 23, 2019

Oops. Missed this comment @PipoCanaja. Sorry for that.

Btw, notification in this repo are only read when update. I suggest to use the librenms.github.io one, so ppl will be notified before merge

PipoCanaja added a commit to librenms/librenms.github.io that referenced this pull request Mar 23, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

PipoCanaja commented Mar 23, 2019

Hi @TheGreatDoc

PR is posted on the librenms.github.io side. And the message is also removed from this PR.

I did not tell "when" this PR will be merged in the notification, feel free to change it in order to sync it with your merge plans :)

Bye

TheGreatDoc added a commit to librenms/librenms.github.io that referenced this pull request Mar 24, 2019

Notification for PR #9903 (#114)
* Notification for PR #9903

Prepare for librenms/librenms#9903

@murrant murrant added this to the 1.50 milestone Mar 24, 2019

@TheGreatDoc
Copy link
Contributor

TheGreatDoc left a comment

LGTM

@TheGreatDoc TheGreatDoc merged commit 743b76e into librenms:master Mar 27, 2019

2 checks passed

codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.