Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grandstream basic support #9906

Merged
merged 4 commits into from Mar 10, 2019

Conversation

Projects
None yet
2 participants
@PipoCanaja
Copy link
Contributor

commented Mar 5, 2019

Grandstream very basic support (MIB pretty bad).

Had to exclude "Linux HT" from the linux.yaml file to match these devices. If anybody has a better idea ...

Will close #8015

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja requested a review from murrant Mar 5, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

@murrant Just a note to double check the change on the linux.yaml file ... Hope it does not break anything ... but ... more eyes is always better

@murrant

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

@PipoCanaja I think linux is treated specially, it is check AFTER all other OS are checked.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

I am not so sure cause during my tests, without the change in the linux.yaml, the device was always detected as linux and not grandstream-ht. And I cleared the os_cache each time I tested. What I did not do is delete the device an create it again every time.

@PipoCanaja PipoCanaja changed the title Grandstream basic support WIP - Grandstream basic support Mar 6, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

Let's WIP this, I'll test again if I can avoid the change in linux.yaml. Will be a little bit less available in the next few days, except if the weather is bad for skiing ...

@PipoCanaja PipoCanaja force-pushed the PipoCanaja:GS branch from b85de88 to d6331ad Mar 10, 2019

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

Works correctly now without touching linux.yaml, so I reverted that.

@PipoCanaja PipoCanaja changed the title WIP - Grandstream basic support Grandstream basic support Mar 10, 2019

@murrant murrant merged commit 6ec9730 into librenms:master Mar 10, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:GS branch Mar 17, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Grandstream basic support (librenms#9906)
* grandstream simple discovery

* grandstream simple discovery tests

* exclusion in linux matching

* Revert un-necessary changes, and change "over:" to ping

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.