Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Infinera Groove discovery #9913

Merged
merged 2 commits into from Mar 10, 2019

Conversation

Projects
None yet
2 participants
@nickhilliard
Copy link
Contributor

commented Mar 6, 2019

  • add support for 3.0.1 and prior versions

  • add support for subports and fibre-channel

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@nickhilliard nickhilliard force-pushed the nickhilliard:bf-infinera-fixes branch 2 times, most recently from 8962a71 to 00fddba Mar 6, 2019

improvements for infinera groove
- add support for 3.0.1 and prior versions

- add support for subports and fibre-channel

- fix bug relating to OS version detection

- updated unit test snmprec

@nickhilliard nickhilliard force-pushed the nickhilliard:bf-infinera-fixes branch from 00fddba to ec807b3 Mar 6, 2019

@label-actions

This comment has been minimized.

Copy link

commented Mar 6, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@nickhilliard Thanx for your PR.
Could you also collect all test data (including the one covered by your change with interfaces and subinterfaces) so that the tests will be more accurate in the future ? And could you please run save-test-data.php as described in the doc to create the json file ?
Thanx

@nickhilliard

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

@PipoCanaja sorry about this, but i have no reliable / useful way of adding this test data at the moment. The devices which have the subinterfaces are running prerelease software with a slightly messed up snmp implementation and the upgrade procedure is outside my control. The patch to infinera-groove.snmprec in this pull request accurately reflects production software from devices which don't have subinterface capability. If the other devices get upgraded at some stage, I'll update infinera-groove.snmprec with a more complete config.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

OK. We can then proceed this PR. Please submit the tests as soon as you get a chance to.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

Quick style upgrade for to make Codeclimate happy again.

@PipoCanaja PipoCanaja changed the title improvements for infinera groove Improved Infinera Groove discovery Mar 10, 2019

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 8d67bb7 into librenms:master Mar 10, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Improved Infinera Groove discovery (librenms#9913)
* Improvements for infinera groove
- add support for 3.0.1 and prior versions
- add support for subports and fibre-channel
- fix bug relating to OS version detection
- updated unit test snmprec

@lock lock bot locked as resolved and limited conversation to collaborators May 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.