Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graylog: Handle missing fields a little more gracefully #9919

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

commented Mar 7, 2019

https://community.librenms.org/t/graylog-integration-returns-500/7561

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the Bug 🐞 label Mar 7, 2019

@awlx

This comment has been minimized.

Copy link

commented Mar 7, 2019

Works!

@murrant murrant merged commit b65205b into librenms:master Mar 8, 2019

4 of 6 checks passed

Travis CI - Pull Request Build Failed
Details
codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:graylog-missing-field branch Mar 8, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.