Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database validation for MySQL 8 #9923

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
3 participants
@llcoolkm
Copy link
Contributor

commented Mar 8, 2019

The validate script reports all timestamp columns as non-compliant because MySQL introduced a new schema in version 8. The extra field now adds "DEFAULT_GENERATED for columns that have an expression default value.". See https://dev.mysql.com/doc/refman/8.0/en/columns-table.html

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant

murrant approved these changes Mar 9, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

Thanks for the fix @llcoolkm

@murrant murrant merged commit 569b1f0 into librenms:master Mar 9, 2019

5 of 6 checks passed

codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@llcoolkm llcoolkm deleted the llcoolkm:validate-breaks-in-mysql-8 branch Mar 22, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.