Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VRP stack state discovery with one member only to avoid unnecessary alarms #9925

Merged
merged 3 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@PipoCanaja
Copy link
Contributor

commented Mar 9, 2019

The YAML implementation cannot identify a device non stacked cause VRP reports it as a stack with 1 member.

So this patch replaces YAML with PHP for this sensor.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

PipoCanaja added some commits Mar 9, 2019

@PipoCanaja PipoCanaja self-assigned this Mar 9, 2019

@PipoCanaja PipoCanaja changed the title WIP - VRP stack state improvement VRP stack state improvement Mar 9, 2019

@PipoCanaja PipoCanaja added the Bug 🐞 label Mar 9, 2019

@PipoCanaja PipoCanaja changed the title VRP stack state improvement Improve VRP stack state discovery when 1 member only to avoid unnecessary alarms Mar 9, 2019

@PipoCanaja PipoCanaja changed the title Improve VRP stack state discovery when 1 member only to avoid unnecessary alarms Improve VRP stack state discovery with one member only to avoid unnecessary alarms Mar 9, 2019

@pubyun

This comment has been minimized.

Copy link

commented Mar 10, 2019

i apply the pull request, the notifications don't disappeared. What else should i do?

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

Hello @pubyun
You should force a discovery (or wait until discovery occurs during the night cron task).
PipoCanaja

@pubyun
Copy link

left a comment

it works

@PipoCanaja PipoCanaja added this to the 1.50 milestone Mar 11, 2019

@PipoCanaja PipoCanaja merged commit 59f00dc into librenms:master Mar 13, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:vrp-stack-patch branch Mar 13, 2019

@murrant murrant removed the Bug 🐞 label Apr 1, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Improved VRP stack state discovery with one member only to avoid unne…
…cessary alarms (librenms#9925)

* VRP stack state improvement

* tests

* cleaning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.