Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Aruba Instant wireless sensors #9936

Merged
merged 2 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@murrant
Copy link
Member

commented Mar 12, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Thanks for the test data @twilley

@murrant murrant added the Device 🖥 label Mar 12, 2019

@murrant murrant merged commit 78ae084 into librenms:master Mar 13, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate 1 fixed issue
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:aruba-ai-fix branch Mar 13, 2019

@kkrumm1

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

For some reason this broke the AP polling for Wireless LAN controller and IAP polling. Any way we can revert this?

@twilley

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

@kkrumm1 I'll take a look on my system - AP polling was already broken on both Instant- and controller-based devices. If you're looking for improved IAP polling, check out #9954 - it still has some code changes that I need to implement (mainly overall AP and client count discovery and polling), but It correctly discovers and polls Instant devices.

@twilley

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Ok, I don't think reverting this will fix controller polling - I think it was already broken before this was merged. I had opened a PR (#9924) to fix controller polling, but then I mistakenly deleted my branch for that PR and the PR was closed - I've resubmitted the code under #10071 which appears to fix controller polling.

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fix Aruba Instant wireless sensors (librenms#9936)
* fix Aruba Instant wireless sensors

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.