Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
fix getOutput, collect all buffer for sync process #9948
fix getOutput, collect all buffer.
before changed, when get graph, got red bar, because getOutput is not completed.
after changed, getOutput always get completed, graph is normal.
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
@rudych Thanks for the PR. We are generally trying to move away from the custom Proc class and move to Symfony Process https://symfony.com/doc/current/components/process.html
murrant left a comment
I'm not sure what this fixes and it seems to skip a check. Maybe that is how it "fixes" your issue.
I'm also not sure this won't break other things. So if we are going to break things, we should just port this to Symfony Process.
as i mention in first comment, getOutput not return in complete output for sync process rrdtool.
RRD[last 10.10.0.1/processor-hr-196608.rrd --daemon rrdcached:42217]
graph /tmp/xEaKh3bU2U7yrExX ... rrdcached:42217
before fixes, first "graph" return "1552503300", which is buffer from "last" cmd.
after fixes, first "graph" will make sure buffer is completed.