Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW OS Aruba Instant #9954

Open
wants to merge 16 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@twilley
Copy link
Contributor

commented Mar 14, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@twilley

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

Aruba Instant and ArubaOS are similar, but are too different to keep together as one OS. My goal is to build the new Aruba Instant OS definition by cloning and improving the current ArubaOS code. Once that has been merged, I will begin re-working the ArubaOS definition

@twilley twilley force-pushed the twilley:newos-arubainstant branch from efcdad3 to c5b4439 Mar 19, 2019

@twilley twilley marked this pull request as ready for review Mar 19, 2019

@twilley twilley changed the title WIP - NEW OS Aruba Instant NEW OS Aruba Instant Mar 21, 2019

Show resolved Hide resolved LibreNMS/OS/ArubaInstant.php Outdated
Show resolved Hide resolved LibreNMS/OS/ArubaInstant.php Outdated
Show resolved Hide resolved includes/polling/functions.inc.php Outdated
Show resolved Hide resolved includes/polling/mempools/aruba-instant.inc.php
$ap_count = 0;
// Count the number of AP MAC addresses (could use AP IPs, Serial Number, etc too.)
$ap_data = snmpwalk_group($device, 'aiAPMACAddress', 'AI-AP-MIB');

This comment has been minimized.

Copy link
@murrant

murrant Mar 21, 2019

Member

This should be done within the wireless code.
Unifi does it for example.
If you can't do it, the wireless module supports custom polling code.

This comment has been minimized.

Copy link
@twilley

twilley Mar 24, 2019

Author Contributor

I'm trying to get a total clients and total aps count for the overview graphs. there's no single oid that has the total number of clients or aps in the cluster, so i have to calculate the totals. is that possible using the wireless sensors code?

This comment has been minimized.

Copy link
@twilley

twilley Mar 24, 2019

Author Contributor

Ok, I'm digging into this, and see how it can be done in the wireless code. Doesn't look too difficult.

This comment has been minimized.

Copy link
@murrant

murrant Apr 12, 2019

Member

You need to implement \LibreNMS\Interfaces\Polling\Sensors\WirelessClientsPolling on your ArubaInstant class.

Then you can basically just put all this code inside the pollWirelessClients function

twilley added some commits Mar 23, 2019

@twilley twilley referenced this pull request Apr 4, 2019

Merged

Fix Aruba Instant wireless sensors #9936

1 of 1 task complete

@kkrumm1 kkrumm1 added the Device 🖥 label Apr 5, 2019

@kkrumm1

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Tested on IAP and it works pulls all the APs May need some tweaking with pull all the memory and processor of the APs. Seen some slowness with pulling 70 + off the IAP. Other than that it works. Thank you @twilley

@murrant
Copy link
Member

left a comment

Still need the client count code move to the wireless module

// Count the number of AP MAC addresses (could use AP IPs, Serial Number, etc too.)
$ap_data = snmpwalk_group($device, 'aiAPMACAddress', 'AI-AP-MIB');
d_echo('Debug Instant aiClientMACAddress: '.PHP_EOL);
d_echo(var_export($ap_data, 1));

This comment has been minimized.

Copy link
@murrant

murrant Apr 12, 2019

Member

You don't need var_export() here, d_echo() already dumps arrays properly

$ap_count = 0;
// Count the number of AP MAC addresses (could use AP IPs, Serial Number, etc too.)
$ap_data = snmpwalk_group($device, 'aiAPMACAddress', 'AI-AP-MIB');

This comment has been minimized.

Copy link
@murrant

murrant Apr 12, 2019

Member

You need to implement \LibreNMS\Interfaces\Polling\Sensors\WirelessClientsPolling on your ArubaInstant class.

Then you can basically just put all this code inside the pollWirelessClients function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.