Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to reflect matching behaviour #9955

Merged
merged 2 commits into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@kiwibrew
Copy link
Contributor

commented Mar 14, 2019

Added a note to help users with matching patterns for Oxidized OS matching patterns.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Update documentation to reflect matching behaviour
Added a note to help users with matching patterns for Oxidized OS matching patterns.
@murrant

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

A good addition, but it is a little more than just lowercase. It requires the system name for an os such as hpe-msa

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

A good addition, but it is a little more than just lowercase. It requires the system name for an os such as hpe-msa

By the way, Is there an easy way to see the os_name other than digging into the YAML file or the DB ?

@murrant

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

I could not think of one other than the raw yaml, or db.

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

I could not think of one other than the raw yaml, or db.

If I think of a place in the GUI that could provide this information, I'll add it.

@murrant

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

How about adding it in tooltips or something?

@murrant murrant merged commit db9c3c9 into librenms:master Mar 19, 2019

3 of 5 checks passed

Travis CI - Pull Request Build Errored
Details
codeclimate Code Climate is analyzing this code.
Details
Inspection Summary
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Update documentation to reflect matching behaviour (librenms#9955)
* Update documentation to reflect matching behaviour

Added a note to help users with matching patterns for Oxidized OS matching patterns.

* Update Oxidized.md

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.