Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new OS - sensatronics-em1 #9960

Merged
merged 4 commits into from Mar 15, 2019

Conversation

Projects
None yet
4 participants
@spencerbutler
Copy link
Contributor

commented Mar 14, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant

This comment has been minimized.

Copy link

commented Mar 14, 2019

CLA assistant check
All committers have signed the CLA.

@murrant
Copy link
Member

left a comment

Looks good nice work

os: sensatronics-em1
text: 'Sensatronics EM1'
type: sensor
icon: generic

This comment has been minimized.

Copy link
@murrant

murrant Mar 14, 2019

Member

It is usually a good idea to add an icon.

This comment has been minimized.

Copy link
@spencerbutler

spencerbutler Mar 14, 2019

Author Contributor

I'll see if I can find an image to create an icon from. Their website is long gone.

Found one quick item

@murrant
Copy link
Member

left a comment

Thanks :)

@murrant murrant merged commit 907579d into librenms:master Mar 15, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

added new OS - sensatronics-em1 (librenms#9960)
* added new OS - sensatronics-em1

* librenms#9960 - added logo, icon, and update skip_values

* librenms#9960 - fixed over: value

* librenms#9960 - updated icon, logo, and updated descr: from static to table names

@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.