Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dell UPS enable rfc 1628 support #9961

Merged
merged 3 commits into from Mar 16, 2019

Conversation

Projects
None yet
3 participants
@PipoCanaja
Copy link
Contributor

commented Mar 14, 2019

Fixes #9957

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@tocks53

This comment has been minimized.

Copy link

commented Mar 15, 2019

hello, thanks for the PR, but, i ha ve an error on github-apply

`librenms@librenms:$ pwd
/opt/librenms
librenms@librenms:
$ ./scripts/github-apply 5926
Checking patch .github/PULL_REQUEST_TEMPLATE.md...
error: while searching for:

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

error: patch failed: .github/PULL_REQUEST_TEMPLATE.md:6
error: .github/PULL_REQUEST_TEMPLATE.md: patch does not apply
Checking patch scripts/github-apply...
error: scripts/github-apply: already exists in working directory
Checking patch scripts/github-remove...
error: scripts/github-remove: already exists in working directory
librenms@librenms:~$
`

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

Hi, @tocks53

It seems that your librenms directory is not clean. You can clean it using the command below but it will kill all the changes you might have done manually.

./scripts/github-remove -d

does ./daily.sh run correctly ? What does ./validate.php says ?

@PipoCanaja PipoCanaja self-assigned this Mar 15, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

@tocks53 You put in the wrong PR number, you should have entered:

 ./scripts/github-apply 9961

@PipoCanaja PipoCanaja merged commit 6f83113 into librenms:master Mar 16, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:dell branch Mar 17, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.