Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed device missing from traps/new Log::event() #9963

Merged
merged 3 commits into from Mar 16, 2019

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

commented Mar 15, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@TheGreatDoc
Copy link
Contributor

left a comment

LGTM + Tested

@TheGreatDoc

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Oh, well, travis complains about it. Im not going to merge until you check and approve it

@murrant

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2019

Done now :)

@TheGreatDoc
Copy link
Contributor

left a comment

LGTM

@TheGreatDoc TheGreatDoc merged commit 3825133 into librenms:master Mar 16, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf changed the title Fix device missing from traps/new Log::event() Fixed device missing from traps/new Log::event() Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fix device missing from traps/new Log::event() (librenms#9963)
* Fix device missing from traps/new Log::event()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.