Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for APC AP9810 zone contacts #9967

Merged
merged 5 commits into from Mar 21, 2019

Conversation

Projects
None yet
4 participants
@cppmonkey
Copy link
Contributor

commented Mar 15, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant

This comment has been minimized.

Copy link

commented Mar 15, 2019

CLA assistant check
All committers have signed the CLA.

cppmonkey added some commits Mar 15, 2019

fix: load is VA, not to be confused with watts. This could be differe…
…nt per device though...

Apparent Power unit = VA
Real Power unit = Watts

And Keeping codeclimate happy

@cppmonkey cppmonkey changed the title WIP device: Added support for APC AP9810 zone contacts feature: Added support for APC AP9810 zone contacts Mar 18, 2019

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 8ec2476 into librenms:master Mar 21, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the Device 🖥 label Mar 31, 2019

@laf laf changed the title feature: Added support for APC AP9810 zone contacts Added support for APC AP9810 zone contacts Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Added support for APC AP9810 zone contacts (librenms#9967)
* device: Added support for APC AP9810 zone contacts

* fix: disconnected sensors been detected. And iemConfigProbesTable certainly does get used and it reference

* fix: load is VA, not to be confused with watts. This could be different per device though...
Apparent Power unit = VA
Real Power unit = Watts

And Keeping codeclimate happy

* feature: updated APC MIB

* feature: added test data for APC Smart UPS SMX750i and AP9810 with contact switches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.