Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HTML transport example for ms teams #9969

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
2 participants
@sorano
Copy link
Contributor

commented Mar 15, 2019

and fix missing " in Processor Alert with Graph example.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Add HTML transport example for ms teams
and fix missing " in Processor Alert with Graph example.
https://server/graphs/id={{ $value['device_id'] }}/type=device_processor/<br>
@endforeach
Template: CPU alert <br>
@endif
@endif
```

#### MS Teams formatted default template:

This comment has been minimized.

Copy link
@murrant

murrant Mar 16, 2019

Member

Why is this ms teams specific?

This comment has been minimized.

Copy link
@sorano

sorano Mar 16, 2019

Author Contributor

Well, I guess it's a somewhat modified truth and probably could be used as a generic template as well.

Reason I called it teams specific is that teams supports limited tags:
https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bots-text-formats

So if someone decides to update the template in the future maybe they would add tags that were not supported in teams.

This comment has been minimized.

Copy link
@murrant

murrant Mar 18, 2019

Member

Hmm, seems like we should have a template collection like we do for alert rules.

@murrant
Copy link
Member

left a comment

LGTM

@murrant murrant merged commit 3f5d8e3 into librenms:master Mar 18, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@sorano sorano deleted the sorano:patch-2 branch Mar 18, 2019

@laf laf changed the title Add HTML transport example for ms teams Added HTML transport example for ms teams Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Add HTML transport example for ms teams (librenms#9969)
and fix missing " in Processor Alert with Graph example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.