Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom storage warning percentage #9975

Merged
merged 6 commits into from Mar 16, 2019

Conversation

Projects
None yet
2 participants
@TheGreatDoc
Copy link
Contributor

commented Mar 16, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

You were waiting for it and you know it!

Was easier than I thought....

@TheGreatDoc TheGreatDoc added the Feature label Mar 16, 2019

@TheGreatDoc TheGreatDoc added this to the 1.50 milestone Mar 16, 2019

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja merged commit 0cc5de6 into librenms:master Mar 16, 2019

5 of 6 checks passed

codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf changed the title Custom storage warning percentage Added support for custom storage warning percentage Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Custom storage warning percentage (librenms#9975)
* Custom storage warning percentage

* Fixed permissions

* Restored line removed by accident

* Fixed permissions v2

* Set correctly the config var

* style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.