Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Getting-Started.md #9976

Merged
merged 2 commits into from Mar 17, 2019

Conversation

Projects
None yet
3 participants
@PipoCanaja
Copy link
Contributor

commented Mar 16, 2019

Following @amigne notification.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@amigne

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2019

I'm wondering if the rendering issue at https://docs.librenms.org/Developing/Getting-Started/#set-up-your-development-git-clone is not caused by the leading space on the line 19 with " ```dotenv".

@PipoCanaja

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2019

@amigne right, that might very well be it!

@amigne

amigne approved these changes Mar 16, 2019

Copy link
Contributor

left a comment

Sounds good to me.

@murrant murrant merged commit ceabfb8 into master Mar 17, 2019

7 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the PipoCanaja-patch-1 branch Mar 17, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Update Getting-Started.md (librenms#9976)
* Update Getting-Started.md

* Update Getting-Started.md

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.